Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume first and last comments are aligned #12366

Merged
merged 1 commit into from
Nov 7, 2023

Commits on Nov 6, 2023

  1. Don't assume first and last comments are aligned

    Currently we use `each_cons(3)` to find comments that align with their
    neighbours, but this means the first and last comments aren't checked.
    We treat them as always aligned, but this leads to false negatives.
    
    We can instead use `each_cons(2)` to look at each pair of comments and
    add both if they're aligned. This does mean that sometimes lines are
    added twice, but this is fine since `Set#<<` is idempotent.
    eugeneius committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    95a9afd View commit details
    Browse the repository at this point in the history