Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12363] Fix incorrect rendering in HTMLFormatter formatter #12364

Conversation

koic
Copy link
Member

@koic koic commented Nov 6, 2023

Fixes #12363.

This PR fixes incorrect rendering of HTML character entities in HTMLFormatter formatter.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic changed the title [Fix #12363] Fix incorrect rendering in Formatter/HTMLFormatter [Fix #12363] Fix incorrect rendering in HTMLFormatter formatter Nov 6, 2023
@koic koic force-pushed the fix_incorrect_rendering_in_formatter_html_formatter branch from 4af6bfb to 32ab9ba Compare November 6, 2023 06:53
Fixes rubocop#12363.

This PR fixes incorrect rendering of HTML character entities in `HTMLFormatter` formatter.
@koic koic force-pushed the fix_incorrect_rendering_in_formatter_html_formatter branch from 32ab9ba to e389a33 Compare November 6, 2023 08:19
@koic koic merged commit c0f5b35 into rubocop:master Nov 6, 2023
28 checks passed
@koic koic deleted the fix_incorrect_rendering_in_formatter_html_formatter branch November 6, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing HTML escape in HTML report of Style/RedundantRegexpArgument
1 participant