[Fix #12337] Support EnforcedStyleForRationalLiterals for Layout/SpaceAroundOperators
#12357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
support_a_new_enforced_style_for_layout_space_around_operators
branch
4 times, most recently
from
30cfc47
to
091539d
Compare
koic
changed the title
EnforcedStyleForSlashInRationalLiterals for Layout/SpaceAroundOperatorsEnforcedStyleForRationalLiterals for Layout/SpaceAroundOperators
bbatsov
reviewed
Nov 5, 2023
| @@ -50,6 +50,20 @@ module Layout | |||
| # | |||
| # # good | |||
| # a ** b | |||
| # | |||
| # @example EnforcedStyleForSlashInRationalLiterals: no_space (default) | |||
There was a problem hiding this comment.
Probably we can we should shorten this to EnforcedStyleForRationalLiterals
There was a problem hiding this comment.
(I mean it's clear that something like this must apply for the slash, as it can't be anything else)
koic
force-pushed
the
support_a_new_enforced_style_for_layout_space_around_operators
branch
from
091539d
to
861cfdc
Compare
…ayout/SpaceAroundOperators` Fixes rubocop#12337. This PR supports `EnforcedStyleForRationalLiterals` option for `Layout/SpaceAroundOperators`. Like `SupportedStylesForExponentOperator` option, the default follows the style guide with `no_space`.
koic
force-pushed
the
support_a_new_enforced_style_for_layout_space_around_operators
branch
from
861cfdc
to
027323b
Compare
|
Thanks! |
koic
deleted the
support_a_new_enforced_style_for_layout_space_around_operators
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12337.
This PR supports
EnforcedStyleForRationalLiteralsoption forLayout/SpaceAroundOperators. LikeSupportedStylesForExponentOperatoroption, the default follows the style guide withno_space.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.