Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12324] Fix an error for Layout/RescueEnsureAlignment #12325

Merged

Conversation

koic
Copy link
Member

@koic koic commented Oct 30, 2023

Fixes #12324.

This PR fixes an error for Layout/RescueEnsureAlignment when using rescue in do...end block assigned to object attribute.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Fixes rubocop#12324.

This PR fixes an error for `Layout/RescueEnsureAlignment`
when using `rescue` in `do`...`end` block assigned to object attribute.
@koic koic force-pushed the fix_error_for_layout_rescue_ensure_alignment branch from bc1eefc to 4b46872 Compare October 31, 2023 13:51
@koic koic merged commit 3e39a76 into rubocop:master Oct 31, 2023
28 checks passed
@koic koic deleted the fix_error_for_layout_rescue_ensure_alignment branch October 31, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout/RescueEnsureAlignment crashes for block results assigned to setter methods on the same line
1 participant