Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12298] Fix a false positive for Style/RedundantParentheses #12299

Merged

Conversation

koic
Copy link
Member

@koic koic commented Oct 20, 2023

Fixes #12298.

This PR fixes a false positive for Style/RedundantParentheses when using a parenthesized hash literal as the first argument in a method call without parentheses.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…ses`

Fixes rubocop#12298.

This PR fixes a false positive for `Style/RedundantParentheses`
when using a parenthesized hash literal as the first argument
in a method call without parentheses.
@koic koic merged commit a797c98 into rubocop:master Oct 20, 2023
28 checks passed
@koic koic deleted the fix_a_false_positive_for_style_redundant_parentheses branch October 20, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/RedundantParentheses autocorrects code into invalid Ruby
1 participant