Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for Style/RedundantDoubleSplatHashBraces #12268

Conversation

koic
Copy link
Member

@koic koic commented Oct 12, 2023

Fixes #12263.

This PR fixes false positives for Style/RedundantDoubleSplatHashBraces when method call for no hash braced double splat receiver.

The code shown in #12263 is incompatible as shown below and is a false positive:

def x(opts) = puts(opts)

h = {foo: :bar}

x(**h.merge(k: :h)) #=> {:foo=>:bar, :k=>:h}
x(k: :v, **h)       #=> {:k=>:v, :foo=>:bar}

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Fixes rubocop#12263.

This PR fixes false positives for `Style/RedundantDoubleSplatHashBraces`
when method call for no hash braced double splat receiver.

The code shown in rubocop#12263 is incompatible as shown below and is a false positive:

```ruby
def x(opts) = puts(opts)

h = {foo: :bar}

x(**h.merge(k: :h)) #=> {:foo=>:bar, :k=>:h}
x(k: :v, **h)       #=> {:k=>:v, :foo=>:bar}
```
@koic koic force-pushed the fix_false_positive_for_style_redundant_double_splat_hash_braces branch from d35aea4 to 3949a00 Compare October 12, 2023 03:16
@bbatsov bbatsov merged commit 128618c into rubocop:master Oct 12, 2023
28 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 12, 2023

Thanks!

@koic koic deleted the fix_false_positive_for_style_redundant_double_splat_hash_braces branch October 12, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In 1.57.0 Style/RedundantDoubleSplatHashBraces autocorrect doesn't seem right
2 participants