Make Lint/RedundantSafeNavigation aware of constant receiver

changelog/new_make_lint_redundant_safe_navigation_aware_of_const_receiver.md

@@ -0,0 +1 @@
+* [#12299](https://github.com/rubocop/rubocop/issues/12299): Make `Lint/RedundantSafeNavigation` aware of constant receiver. ([@koic][])

lib/rubocop/cop/lint/redundant_safe_navigation.rb

@@ -4,8 +4,12 @@ module RuboCop
   module Cop
     module Lint
       # Checks for redundant safe navigation calls.
-      # `instance_of?`, `kind_of?`, `is_a?`, `eql?`, `respond_to?`, and `equal?` methods
-      # are checked by default. These are customizable with `AllowedMethods` option.
+      # Use cases where a constant is `nil` are rare and an offense is detected
+      # when the receiver is a constant.
+      #
+      # For all receivers, the `instance_of?`, `kind_of?`, `is_a?`, `eql?`, `respond_to?`,
+      # and `equal?` methods are checked by default.
+      # These are customizable with `AllowedMethods` option.
       #
       # The `AllowedMethods` option specifies nil-safe methods,
       # in other words, it is a method that is allowed to skip safe navigation.
@@ -22,6 +26,9 @@ module Lint
       #
       # @example
       #   # bad
+      #   Const&.do_something
+      #
+      #   # bad
       #   do_something if attrs&.respond_to?(:[])
       #
       #   # good
@@ -33,6 +40,9 @@ module Lint
       #   end
       #
       #   # good
+      #   Const.do_something
+      #
+      #   # good
       #   while node.is_a?(BeginNode)
       #     node = node.parent
       #   end
@@ -63,8 +73,10 @@ class RedundantSafeNavigation < Base
         PATTERN
 
         def on_csend(node)
-          return unless check?(node) && allowed_method?(node.method_name)
-          return if respond_to_nil_specific_method?(node)
+          unless node.receiver.const_type?
+            return unless check?(node) && allowed_method?(node.method_name)
+            return if respond_to_nil_specific_method?(node)
+          end
 
           range = range_between(node.loc.dot.begin_pos, node.source_range.end_pos)
           add_offense(range) { |corrector| corrector.replace(node.loc.dot, '.') }

spec/rubocop/cop/lint/redundant_safe_navigation_spec.rb

@@ -3,6 +3,17 @@
 RSpec.describe RuboCop::Cop::Lint::RedundantSafeNavigation, :config do
   let(:cop_config) { { 'AllowedMethods' => %w[respond_to?] } }
 
+  it 'registers an offense and corrects when `&.` is used for const receiver' do
+    expect_offense(<<~RUBY)
+      Foo&.do_something
+         ^^^^^^^^^^^^^^ Redundant safe navigation detected.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      Foo.do_something
+    RUBY
+  end
+
   it 'registers an offense and corrects when `&.` is used inside `if` condition' do
     expect_offense(<<~RUBY)
       if foo&.respond_to?(:bar)