Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12237] Fix Style/NestedTernaryOperator autocorrection to support conditionals between nested ternaries #12239

Conversation

stevegeek
Copy link

This fixes issue #12237 to ensure that when autocorrecting the cop looks for parent ternaries, and not just any if node.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Fix autocorrection to correctly support conditionals between nested ternaries.
@koic
Copy link
Member

koic commented Oct 2, 2023

I've already opened #12238 as a simpler solution. Thank you!

@koic koic closed this Oct 2, 2023
@stevegeek
Copy link
Author

ok cool thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants