Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Style/FormatString's autocorrection #12234

Merged

Conversation

koic
Copy link
Member

@koic koic commented Sep 30, 2023

This PR enhances Style/FormatString's autocorrection when using known conversion methods whose return value is not an array.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@bbatsov
Copy link
Collaborator

bbatsov commented Oct 5, 2023

Might be a good idea to document the autocorrection logic, so users know what to expect.

This PR enhances `Style/FormatString`'s autocorrection
when using known conversion methods whose return value is not an array.
@koic
Copy link
Member Author

koic commented Oct 5, 2023

Sure! I've updated the document.

@koic koic force-pushed the enhance_style_format_string_autocorrection branch from 5195776 to b9a90b5 Compare October 5, 2023 15:03
@koic koic merged commit a455e9d into rubocop:master Oct 6, 2023
28 checks passed
@koic koic deleted the enhance_style_format_string_autocorrection branch October 6, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants