Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12226] Fix false positives for Layout/MultilineMethodCallIndentation #12230

Conversation

koic
Copy link
Member

@koic koic commented Sep 29, 2023

Fixes #12226.

This PR fixes false positives for Layout/MultilineMethodCallIndentation when aligning methods in multiline block chain.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…llIndentation`

Fixes rubocop#12226.

This PR fixes false positives for `Layout/MultilineMethodCallIndentation`
when aligning methods in multiline block chain.
@koic koic force-pushed the fix_false_positives_for_layout_multiline_method_call_indentation branch from 958c85a to a036ab4 Compare September 30, 2023 05:27
@bbatsov bbatsov merged commit 5f17749 into rubocop:master Sep 30, 2023
28 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Sep 30, 2023

Looks good to me! Thanks!

@koic koic deleted the fix_false_positives_for_layout_multiline_method_call_indentation branch September 30, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive on Layout/MultilineMethodCallIndentation cop
2 participants