Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect autocorrect for Style/OperatorMethodCall #12206

Conversation

koic
Copy link
Member

@koic koic commented Sep 18, 2023

This PR fixes an incorrect autocorrect for Style/OperatorMethodCall when using foo./bar:

% echo 'arg./100.0' | bundle exec rubocop --stdin example.rb -a -d
(snip)

F

Offenses:

example.rb:1:4: C: [Corrected] Style/OperatorMethodCall: Redundant dot detected.
arg./100.0
   ^
example.rb:1:5: F: Lint/Syntax: ambiguous first argument; put parentheses or a space even after the operator
(Using Ruby 2.7 parser; configure using TargetRubyVersion parameter, under AllCops)
arg /100.0
    ^

1 file inspected, 2 offenses detected, 1 offense corrected
====================
arg /100.0

It solves the above Lint/Syntax.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the fix_an_incorrect_autocorrect_for_style_operator_method_call branch 3 times, most recently from e53f2a6 to 9c4ed0f Compare September 18, 2023 07:54
This PR fixes an incorrect autocorrect for `Style/OperatorMethodCall` when using `foo./bar`:

```console
% echo 'arg./100.0' | bundle exec rubocop --stdin example.rb -a -d
(snip)

F

Offenses:

example.rb:1:4: C: [Corrected] Style/OperatorMethodCall: Redundant dot detected.
arg./100.0
   ^
example.rb:1:5: F: Lint/Syntax: ambiguous first argument; put parentheses or a space even after the operator
(Using Ruby 2.7 parser; configure using TargetRubyVersion parameter, under AllCops)
arg /100.0
    ^

1 file inspected, 2 offenses detected, 1 offense corrected
====================
arg /100.0
```

It solves the above `Lint/Syntax`.
@koic koic force-pushed the fix_an_incorrect_autocorrect_for_style_operator_method_call branch from 9c4ed0f to 1483f31 Compare September 19, 2023 02:14
@koic koic merged commit 9fdc532 into rubocop:master Sep 19, 2023
28 checks passed
@koic koic deleted the fix_an_incorrect_autocorrect_for_style_operator_method_call branch September 19, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant