Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12154] Fix incorrect diagnosticProvider value of LSP #12158

Merged

Conversation

koic
Copy link
Member

@koic koic commented Aug 27, 2023

Fixes #12154.

This PR fixes incorrect diagnosticProvider value of LSP.

diagnosticProvider cannot accept true as below. This PR replaces the originally acceptable value.

/**
 * The server has support for pull model diagnostics.
 *
 * @since 3.17.0
 */
diagnosticProvider?: DiagnosticOptions | DiagnosticRegistrationOptions;

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#initialize


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Fixes rubocop#12154.

This PR fixes incorrect `diagnosticProvider` value of LSP.

`diagnosticProvider` cannot accept true as below. This PR replaces the originally acceptable value.

```typescript
/**
 * The server has support for pull model diagnostics.
 *
 * @SInCE 3.17.0
 */
diagnosticProvider?: DiagnosticOptions | DiagnosticRegistrationOptions;
```

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#initialize
@bbatsov bbatsov merged commit c4cb471 into rubocop:master Aug 28, 2023
28 checks passed
@koic koic deleted the fix_incorrect_diagnostic_provider_value_of_lsp branch August 28, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP diagnosticProvider seems not following the specifications
2 participants