[Fix #12138] Fix a false positive for Layout/LineContinuationLeadingSpace
#12139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Aug 23, 2023
| end | ||
| end |
There was a problem hiding this comment.
Can you refactor to the below?
lines = raw_lines(node)
lines.each_cons(2).with_index(node.first_line) do |(raw_line_one, raw_line_two), line_num|
end_of_first_line += raw_line_one.length
next unless continuation?(raw_line_one, line_num, node)
investigate(raw_line_one, raw_line_two, end_of_first_line)
end
koic
reviewed
Aug 23, 2023
| @@ -0,0 +1 @@ | |||
| * [#12138](https://github.com/rubocop/rubocop/issues/12138): Fix false positives for `Layout/LineContinuationLeadingSpace`. ([@ymap][]) | |||
There was a problem hiding this comment.
Can you add a little more false positive information?
…LeadingSpace` Fixes rubocop#12138. This PR fixes a false positive for `Layout/LineContinuationLeadingSpace` when a backslash is part of a multiline string literal.
ymap
force-pushed
the
fix_a_false_positive_for_layout_line_continuation_leading_space
branch
from
d7b1c39
to
5b47705
Compare
|
@koic Thanks for the review! I've amended the commit. |
|
Thanks! |
ymap
deleted the
fix_a_false_positive_for_layout_line_continuation_leading_space
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12138.
This PR fixes a false positive for
Layout/LineContinuationLeadingSpacewhen a backslash is part of a multiline string literal.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.