Fix Style/RedundantSelfAssignmentBranch
to handle heredocs
#12133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the autocorrection of
Style/RedundantSelfAssignmentBranch
, which causes the following replacement ifopposite_branch
is a heredoc.Before:
After:
So in this pull request, I will modify it to make up for the missing parts in the case of heredoc.
This implementation is roughly the same as other methods of dealing with heredocs, for example, in
Style/FileWrite
:rubocop/lib/rubocop/cop/style/file_write.rb
Lines 108 to 121 in dd29994
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.