[Fix #12113] Fix a false positive for Bundler/DuplicatedGroup
#12116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_a_false_positive_for_bundler_duplicated_group
branch
from
f445cf7
to
d950800
Compare
|
I tried your branch against our Gemfile, the offense is gone now. |
koic
force-pushed
the
fix_a_false_positive_for_bundler_duplicated_group
branch
3 times, most recently
from
3289ac2
to
2b67045
Compare
|
@timon Great information! I've updated the PR to accommodate those blocks. |
|
I think it'd be good to also add some examples covering this and keyword arguments to the docs, so it's clearer for users how the cop reasons about those. |
koic
force-pushed
the
fix_a_false_positive_for_bundler_duplicated_group
branch
from
2b67045
to
cd15eea
Compare
|
Sure, I've documented an acceptance case covered by this PR. |
Fix rubocop#12113. This PR fixes a false positive for `Bundler/DuplicatedGroup` when groups are duplicated but `source`, `git`, `platforms`, or `path` values are different.
koic
force-pushed
the
fix_a_false_positive_for_bundler_duplicated_group
branch
from
cd15eea
to
5da5286
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12113.
This PR fixes a false positive for
Bundler/DuplicatedGroupwhen groups are duplicated butsource,git,platforms, orpathvalues are different.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.