With --fail-level A ignore non-correctable offenses at :info severity
#12091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveg
force-pushed
the
naveg/fail-level-autocorrect
branch
from
aa1b9cb
to
06eb546
Compare
naveg
force-pushed
the
naveg/fail-level-autocorrect
branch
from
06eb546
to
11417cd
Compare
|
@naveg The proposed changes make sense, but they have to be clearly documented. I doubt many people will manage to infer this by themselves. |
The current implementation of `--fail-level autocorrect` fails for all offenses, no matter what. Notably, this includes non-correctable offenses with the :info severity. Change the implementation to only fail: * Any _correctable_ offense, regardless of severity * Non-correctable offenses with severity :refactor (the default) or higher
naveg
force-pushed
the
naveg/fail-level-autocorrect
branch
from
11417cd
to
817b3d2
Compare
|
Thanks @bbatsov - I updated the documentation for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
--fail-level autocorrectfails for alloffenses, no matter what. Notably, this includes non-correctable
offenses with the :info severity.
Change the implementation to only fail:
higher
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.