[Fix #12071] Fix Style/SymbolArray false positives when using square brackets or interpolation in a symbol literal within a percent style array
#12088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Aug 1, 2023
| @@ -0,0 +1 @@ | |||
| * [#12071](https://github.com/rubocop/rubocop/issues/12071): Fix `Style/SymbolArray` false positives. ([@jasondoc3][]) | |||
There was a problem hiding this comment.
Can you add a little more information to the description about what will be fixed?
There was a problem hiding this comment.
Added a bit more detail here
jasondoc3
force-pushed
the
jason/fix-false-positive-symbol-array
branch
from
5233ac1
to
0fce99b
Compare
jasondoc3
changed the title
Style/SymbolArray false positives when using square brackets or interpolation in a symbol literal within a percent style array
jasondoc3
force-pushed
the
jason/fix-false-positive-symbol-array
branch
from
0fce99b
to
8e83725
Compare
koic
reviewed
Aug 1, 2023
| content = content.to_s | ||
| content_without_delimiter_pairs = content.gsub(/(\[\])|(\(\))/, '') | ||
| content = *sym | ||
| content = content.map { |c| c.respond_to?(:str_content) ? c.str_content : c.to_s }.join |
There was a problem hiding this comment.
Can you refactor to below?
Suggested change
| content = content.map { |c| c.respond_to?(:str_content) ? c.str_content : c.to_s }.join | |
| content = content.map { |c| c.is_a?(AST::Node) ? c.source : c }.join |
There was a problem hiding this comment.
Yes. That is much clearer 🙌 . I was looking for a more concise way to check this other than using respond_to?. Done
jasondoc3
force-pushed
the
jason/fix-false-positive-symbol-array
branch
3 times, most recently
from
b6ead16
to
ed09cd5
Compare
|
Looks good to me. Can you squash your commits into one? |
jasondoc3
force-pushed
the
jason/fix-false-positive-symbol-array
branch
from
ed09cd5
to
c5cefae
Compare
|
@koic Squashed. Thanks for the quick review |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12071. Some false positives offenses were introduced in #12037.
For example,
%I[#{one}_two three]and%i[one[2] three]are currently returning offenses when they should not be.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.