Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LSP server support rubocop.formatAutocorrectsAll execute command #12078

Conversation

koic
Copy link
Member

@koic koic commented Jul 28, 2023

This PR makes LSP server support rubocop.formatAutocorrectsAll execute command. The user can run rubocop -A with the execute command in the editor.

The existing rubocop.formatAutocorrects execute command equivalent to rubocop -a can be used as follows: https://github.com/rubocop/vscode-rubocop#manually-triggering-a-format-with-autocorrects

The new rubocop.formatAutocorrectsAll execute command is the provide execute command for that rubocop -A.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR makes LSP server support `rubocop.formatAutocorrectsAll` execute command.
The user can run `rubocop -A` with the execute command in the editor.

The existing `rubocop.formatAutocorrects` execute command equivalent to `rubocop -a` can be used as follows:
https://github.com/rubocop/vscode-rubocop#manually-triggering-a-format-with-autocorrects

The new `rubocop.formatAutocorrectsAll` execute command is the provide execute command for that `rubocop -A`.
@koic koic force-pushed the make_lsp_server_support_format_autocorrects_all_execute_command branch from 963cb81 to b718290 Compare July 28, 2023 18:07
@bbatsov bbatsov merged commit f94f426 into rubocop:master Aug 3, 2023
28 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 3, 2023

Thanks!

@koic koic deleted the make_lsp_server_support_format_autocorrects_all_execute_command branch August 3, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants