Fix a false negative for Layout/ExtraSpacing
#12043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a false negative for
Layout/ExtraSpacing
when some character are vertically aligned.For example, there is a wasted space before the
do
keyword.The
d
char is accidentally vertically aligned and cannot be detected:Looking at the test code, it looks like this is to allow vertical alignment of dots in method calls:
https://github.com/rubocop/rubocop/blob/v1.54.1/spec/rubocop/cop/layout/extra_spacing_spec.rb#L172-L177
Therefore, this PR tweaks the alignment logic to be closer to the expected behavior.
And it also suppresses the following new offenses found with this tweak:
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.