Fix an error for Style/YodaCondition
#12009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jul 1, 2023
| @@ -324,6 +324,10 @@ | |||
| expect_no_offenses('bar === "foo"') | |||
| end | |||
|
|
|||
| it 'accepts equality check method is used without RHSl' do | |||
There was a problem hiding this comment.
RHSl? Perhaps argument is the better term here.
There was a problem hiding this comment.
Sure! I've updated this PR.
This PR fixes an error for `Style/YodaCondition` when equality check method is used without the first argument: ```ruby foo.== ``` ```console % rubocop /tmp/example.rb --only Style/YodaCondition -d (snip) For /tmp: An error occurred while Style/YodaCondition cop was inspecting /tmp/example.rb:1:0. undefined method `literal?' for nil:NilClass An error occurred while Style/YodaCondition cop was inspecting /tmp/example.rb:1:0. undefined method `literal?' for nil /Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/rubocop-1.53.1/lib/ rubocop/cop/style/yoda_condition.rb:144:in `constant_portion?' /Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/rubocop-1.53.1/lib/ rubocop/cop/style/yoda_condition.rb:126:in `valid_yoda?' ```
koic
force-pushed
the
fix_an_error_for_style_yoda_condition
branch
from
585c6f4
to
757737b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error for
Style/YodaConditionwhen equality check method is used without the first argument:Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.