Support safe or unsafe autocorrect config for LSP #12000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
support_safe_autocorrect_config_for_lsp
branch
from
d359d2a
to
81d6d34
Compare
This PR supports safe or unsafe autocorrect config for LSP.
The autocorrection is still safe by default (`rubocop -a`).
LSP client can switch to unsafe autocorrection (`rubocop -A`) by passing the following
`safeAutocorrect` parameter in the `initialize` request.
```json
{
"jsonrpc": "2.0",
"id": 42,
"method": "initialize",
"params": {
"initializationOptions": {
"safeAutocorrect": false
}
}
}
```
Some users may want to set unsafe autocorrection as the default for the LSP,
understanding the risks involved.
However, considering that the default should be safe, unsafe is an option.
koic
force-pushed
the
support_safe_autocorrect_config_for_lsp
branch
from
81d6d34
to
19048c6
Compare
|
Nice improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports safe or unsafe autocorrect config for LSP.
The autocorrection is still safe by default (
rubocop -a).LSP client can switch to unsafe autocorrection (
rubocop -A) by passing the followingsafeAutocorrectparameter in theinitializerequest.{ "jsonrpc": "2.0", "id": 42, "method": "initialize", "params": { "initializationOptions": { "safeAutocorrect": false } } }Some users may want to set unsafe autocorrection as the default for the LSP, understanding the risks involved.
However, considering that the default should be safe, unsafe is an option.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.