Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ridgepole files to default Include list #11983

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented Jun 26, 2023

With ridgepole, we can write Ruby DSLs in files called Schemafile or .schema.
https://github.com/ridgepole/ridgepole

For example:

create_table "users", force: :cascade do |t|
  t.string   "last_name"
  t.string   "first_name"
  t.virtual  "full_name", type: :string, as: "concat(`last_name`,' ',`first_name`)", stored: true
end

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

With ridgepole, we can write Ruby DSLs in files called `Schemafile` or `.schema`.
https://github.com/ridgepole/ridgepole

For example:
```ruby
create_table "users", force: :cascade do |t|
  t.string   "last_name"
  t.string   "first_name"
  t.virtual  "full_name", type: :string, as: "concat(`last_name`,' ',`first_name`)", stored: true
end
```
@ydah ydah changed the title Add *.schema and Schemafile to default Include list Add Ridgepole files to default Include list Jun 26, 2023
@bbatsov bbatsov merged commit 16b8934 into rubocop:master Jun 26, 2023
29 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 26, 2023

Thanks!

@ydah ydah deleted the add-schema-in-default branch June 30, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants