Commits on Jun 12, 2023

1. Fix an incorrect autocorrect for Style/SoleNestedConditional …

   This PR fixes an incorrect autocorrect for `Style/SoleNestedConditional` with
   `Style/MethodCallWithArgsParentheses`.
   
   ```ruby
   if items.include? item
     if condition
       do_something
     end
   end
   ```
   
   ## Before
   
   ```console
   $ bundle exec rubocop -a --only Style/MethodCallWithArgsParentheses,Style/SoleNestedConditional
   Inspecting 1 file
   F
   
   Offenses:
   
   example.rb:1:4: C: [Corrected] Style/MethodCallWithArgsParentheses: Use parentheses for method calls with arguments.
   if items.include? item
      ^^^^^^^^^^^^^^^^^^^
   example.rb:1:24: F: Lint/Syntax: unexpected token tRPAREN
   (Using Ruby 3.3 parser; configure using TargetRubyVersion parameter, under AllCops)
   if items.include?(item)) && condition
                          ^
   example.rb:2:3: C: [Corrected] Style/SoleNestedConditional: Consider merging nested conditions into outer if conditions.
     if condition
     ^^
   example.rb:3:3: F: Lint/Syntax: unexpected token kEND
   (Using Ruby 3.3 parser; configure using TargetRubyVersion parameter, under AllCops)
     end
     ^^^
   
   1 file inspected, 4 offenses detected, 2 offenses corrected
   ```
   
   Syntax error with redundant closing parentheses.
   
   ```console
   if items.include?(item)) && condition
       do_something
     end
   ```
   
   ## After
   
   Valid syntax.
   
   ```console
   if items.include?(item) && condition
       do_something
     end
   ```

   

   koic committed Jun 12, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 809c1a8
   • Browse repository at this point

   Copy the full SHA

   809c1a8 View commit details

   Browse the repository at this point in the history