Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #11919] Fix an error for Lint/UselessAssignment #11921

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

koic
Copy link
Member

@koic koic commented Jun 3, 2023

Fixes #11919.

This PR fixes an error for Lint/UselessAssignment when a variable is assigned and unreferenced in for.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Fixes rubocop#11919.

This PR fixes an error for `Lint/UselessAssignment`
when a variable is assigned and unreferenced in `for`.
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 4, 2023

Looks good. Thanks!

@bbatsov bbatsov merged commit 728457d into rubocop:master Jun 4, 2023
28 checks passed
@koic koic deleted the fix_error_for_lint_useless_assignment branch June 4, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VariableForce error with for
2 participants