Make Lint/RedundantStringCoercion aware of print method arguments
#11779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
make_lint_redundant_string_coercion_aware_of_print_method_arguments
branch
2 times, most recently
from
b8019cd
to
f19a214
Compare
bbatsov
reviewed
Apr 10, 2023
| # which is redundant. | ||
| # | ||
| # @example | ||
| # | ||
| # # bad | ||
| # | ||
| # "result is #{something.to_s}" | ||
| # print something.to_s | ||
| # puts something.to_s |
There was a problem hiding this comment.
Seems you forgot warn something.to_s here.
Totally agree. |
This PR makes `Lint/RedundantStringCoercion` aware of print method arguments. The name of this cop is "RedundantStringCoercion", so it makes more sense to extend the feature than to provide a new cop I think.
koic
force-pushed
the
make_lint_redundant_string_coercion_aware_of_print_method_arguments
branch
from
f19a214
to
d3d7061
Compare
koic
deleted the
make_lint_redundant_string_coercion_aware_of_print_method_arguments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Lint/RedundantStringCoercionaware of print method arguments. The name of this cop is "RedundantStringCoercion", so it makes more sense to extend the feature than to provide a new cop I think.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.