Fix a false positive for Style/RedundantLineContinuation when using && and || with a multiline condition
#11754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
force-pushed
the
fix-false-positive-for-RedundantLineContinuation
branch
from
9437438
to
8b0a0c5
Compare
This was referenced Apr 3, 2023
|
Can you squash your commits into one? Because this is a fix around the operator, and according to Martin Fowler's theory of the "Refactoring" book, I don't think it makes sense to commit it as a separate refactoring. |
ydah
force-pushed
the
fix-false-positive-for-RedundantLineContinuation
branch
from
8b0a0c5
to
7437296
Compare
|
Thank you very much. I understand. I squashed the commits. |
koic
reviewed
Apr 3, 2023
koic
reviewed
Apr 3, 2023
… `&&` and `||` with a multiline condition. Follow up: rubocop#11694 (comment) This PR fixes a false positive for `Style/RedundantLineContinuation` when using `&&` and `||` with a multiline condition.
ydah
force-pushed
the
fix-false-positive-for-RedundantLineContinuation
branch
from
7437296
to
c54405b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up: #11694 (comment)
This PR fixes a false positive for
Style/RedundantLineContinuationwhen using&&and||with a multiline condition.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.