Add new Lint/DuplicateMatchPattern cop
#11749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Apr 1, 2023
| module Lint | ||
| # Checks that there are no repeated patterns used in `in` keywords. | ||
| # | ||
| # @example |
There was a problem hiding this comment.
It'd be nice to show examples with more complex patterns, so it's clear that this cop is pretty smart about them.
|
I wonder if |
This PR adds new `Lint/DuplicateMatchPattern` cop. It checks that there are no repeated patterns used in `in` keywords. ```ruby # bad case x in 'first' do_something in 'first' do_something_else end # good case x in 'first' do_something in 'second' do_something_else end ``` I was wondering whether to extend existing `Lint/DuplicateCaseCondition`, but it is a different inspection target from the concept named "`case` condition". So, I implemented it as a new `Lint/DuplicateMatchPattern` for "match pattern".
koic
changed the title
Lint/DuplicateInPattern copLint/DuplicateMatchPattern cop
koic
force-pushed
the
add_new_lint_duplicate_in_pattern_cop
branch
from
a3bb23d
to
a910f15
Compare
|
Thank you for the suggestions. |
|
Looks great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new
Lint/DuplicateMatchPatterncop. It checks that there are no repeated patterns used ininkeywords.I was wondering whether to extend existing
Lint/DuplicateCaseCondition, but it is a different inspection target from the concept named "casecondition". So, I implemented it as a newLint/DuplicateMatchPatternfor "match pattern".Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.