Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Lint/NestedMethodDefinition when nested definition inside *_eval and *_exec method call with a numblock #11740

Merged

Conversation

ydah
Copy link
Member

@ydah ydah commented Mar 27, 2023

This PR fix a false positive for Lint/NestedMethodDefinition when nested definition inside *_eval and *_exec method call with a numblock.

class Foo
  def x(obj)
    obj.instance_eval do
      @bar = _1
      def y
      end
    end
  end
end

class Foo
  def x(obj)
    obj.instance_exec(3) do
      @bar = _1
      def y
      end
    end
  end
end

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • [-] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…finition inside `*_eval` and `*_exec` method call with a numblock

This PR fix a false positive for `Lint/NestedMethodDefinition` when nested definition inside `*_eval` and `*_exec` method call with a numblock.

```ruby
class Foo
  def x(obj)
    obj.instance_eval do
      @bar = _1
      def y
      end
    end
  end
end

class Foo
  def x(obj)
    obj.instance_exec(3) do
      @bar = _1
      def y
      end
    end
  end
end
```
@ydah ydah force-pushed the fix-false-positive-lint-nested-method-definition branch from aeaa400 to 3fec432 Compare March 27, 2023 09:52
@koic koic merged commit 225878a into rubocop:master Mar 28, 2023
@ydah ydah deleted the fix-false-positive-lint-nested-method-definition branch March 28, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants