Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Style/RedundantParentheses aware of redundant method arg parentheses #11739

Conversation

koic
Copy link
Member

@koic koic commented Mar 27, 2023

This PR makes Style/RedundantParentheses aware of redundant method argument parentheses.

The following is an example:

x.y.((z))

Before

$ bundle exec rubocop --only Style/RedundantParentheses -a
Inspecting 1 file
.

1 file inspected, no offenses detected

After

$ bundle exec rubocop --only Style/RedundantParentheses -a
Inspecting 1 file
C

Offenses:

example.rb:1:6: C: [Corrected] Style/RedundantParentheses: Don't use parentheses around a method call.
x.y.((z))
     ^^^

1 file inspected, 1 offense detected, 1 offense corrected

$ cat example.rb
x.y.(z)

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…theses

This PR makes `Style/RedundantParentheses` aware of redundant method argument parentheses.

The following is an example:

```ruby
x.y.((z))
```

## Before

```console
$ bundle exec rubocop --only Style/RedundantParentheses -a
Inspecting 1 file
.

1 file inspected, no offenses detected
```

## After

```console
$ bundle exec rubocop --only Style/RedundantParentheses -a
Inspecting 1 file
C

Offenses:

example.rb:1:6: C: [Corrected] Style/RedundantParentheses: Don't use parentheses around a method call.
x.y.((z))
     ^^^

1 file inspected, 1 offense detected, 1 offense corrected

$ cat example.rb
x.y.(z)
```
@koic koic merged commit 3908944 into rubocop:master Mar 28, 2023
11 checks passed
@koic koic deleted the make_style_redundant_parentheses_aware_of_method_arg_parentheses branch March 28, 2023 16:12
sambostock added a commit to sambostock/rubocop-minitest that referenced this pull request Oct 23, 2023
rubocop/rubocop#11739 updated `Style/RedundantParentheses` to detect
this, so we can now consider it out of scope of these cops, as was done
in https://github.com/rubocop/rubocop-minitest/pull/248/files#r1150046949.
sambostock added a commit to sambostock/rubocop-minitest that referenced this pull request Oct 23, 2023
rubocop/rubocop#11739 updated `Style/RedundantParentheses` to detect
this, so we can now consider it out of scope of these cops, as was done
in https://github.com/rubocop/rubocop-minitest/pull/248/files#r1150046949.
sambostock added a commit to sambostock/rubocop-minitest that referenced this pull request Oct 23, 2023
rubocop/rubocop#11739 updated `Style/RedundantParentheses` to detect
this, so we can now consider it out of scope of these cops, as was done
in https://github.com/rubocop/rubocop-minitest/pull/248/files#r1150046949.
sambostock added a commit to sambostock/rubocop-minitest that referenced this pull request Oct 23, 2023
rubocop/rubocop#11739 updated `Style/RedundantParentheses` to detect
this, so we can now consider it out of scope of these cops, as was done
in https://github.com/rubocop/rubocop-minitest/pull/248/files#r1150046949.
koic pushed a commit to koic/rubocop-minitest that referenced this pull request Nov 27, 2023
rubocop/rubocop#11739 updated `Style/RedundantParentheses` to detect
this, so we can now consider it out of scope of these cops, as was done
in https://github.com/rubocop/rubocop-minitest/pull/248/files#r1150046949.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant