[Fix #11704] Fix a false positive for Lint/UselessMethodDefinition
#11705
+63
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Mar 18, 2023
| end | ||
| alias on_defs on_def | ||
|
|
||
| private | ||
|
|
||
| def modifiered_method_definition?(node) |
There was a problem hiding this comment.
I'd go with "method_definition_with_modifier?" here.
bbatsov
reviewed
Mar 18, 2023
| @@ -170,6 +214,14 @@ def method(x: 1) | |||
| RUBY | |||
| end | |||
|
|
|||
| it 'does not register an offense when method definition with non access modifier containing only `super` call' do | |||
There was a problem hiding this comment.
Technically speaking if it's not an access modifier we should probably call it should else - e.g. "generic method macro" or whatever. I'm not sure what's the best terminology here.
There was a problem hiding this comment.
I'm not sure the best terminology, but I think "generic method macro" is definitely a better name. Thank you for the suggestion! I've updated this PR.
…ition` Fixes rubocop#11704. This PR fixes a false positive for `Lint/UselessMethodDefinition` when method definition with non access modifier containing only `super` call.
koic
force-pushed
the
fix_a_false_positive_for_lint_useless_method_definition
branch
from
f7f54e4
to
82b0479
Compare
koic
deleted the
fix_a_false_positive_for_lint_useless_method_definition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11704.
This PR fixes a false positive for
Lint/UselessMethodDefinitionwhen method definition with non access modifier containing onlysupercall.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.