Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Gemspec/DependencyVersion #11691

Merged

Commits on Mar 12, 2023

  1. Fix an error for Gemspec/DependencyVersion

    This PR fixes the following error for `Gemspec/DependencyVersion`
    when `add_dependency` without version argument and method called on gem name argument:
    
    ```ruby
    Gem::Specification.new do |spec|
      spec.add_dependency('parser'.freeze)
    end
    ```
    
    ```console
    $ bundle exec rubocop --only Gemspec/DependencyVersion -d
    (snip)
    
    undefined method `value' for s(:send,
      s(:str, "parser"), :freeze):RuboCop::AST::SendNode
    /Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/gemspec/dependency_version.rb:97:in `allowed_gem?'
    /Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/gemspec/dependency_version.rb:84:in `on_send'
    /Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/commissioner.rb:143:in `public_send'
    ```
    koic committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    a3b8a8d View commit details
    Browse the repository at this point in the history