Fix incorrect Style/HashSyntax autocorrection for assignment methods #11673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsamokovarov
force-pushed
the
hash-syntax-in-assignment
branch
from
087229c
to
d65c82b
Compare
In Ruby 3.1 and above, code like:
```ruby
object.attr = {foo: foo}
^^^ Omit the hash value.
pass
```
was incorrectly autocorrected to:
```ruby
object.attr({foo:})
pass
```
The autocorrected code is valid Ruby, but is semantically different.
This may and will lead to subtle bugs in user codebases.
gsamokovarov
force-pushed
the
hash-syntax-in-assignment
branch
from
d65c82b
to
693796e
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby 3.1 and above, code like:
was incorrectly autocorrected to:
The autocorrected code is valid Ruby but is semantically different. This may, and will, lead to subtle bugs in user codebases.