Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Style/RedundantParentheses cop for lambdas #12380

Closed
ydakuka opened this issue Nov 10, 2023 · 1 comment · Fixed by #12381
Closed

Improve Style/RedundantParentheses cop for lambdas #12380

ydakuka opened this issue Nov 10, 2023 · 1 comment · Fixed by #12381

Comments

@ydakuka
Copy link

ydakuka commented Nov 10, 2023

Actual behavior

I have the following code:

class Post < ApplicationRecord
  scope :published1, (lambda do
    foo
  end)

  scope :published2, (-> { bar })
end

Terminal:

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop app/models/post.rb 
Inspecting 1 file
.

1 file inspected, no offenses detected

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.57.2 (using Parser 3.2.2.4, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.22.0
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.25.0
  - rubocop-thread_safety 0.5.1
@ydakuka
Copy link
Author

ydakuka commented Nov 10, 2023

And for the next examples there is a wrong indentation, but rubocop does not detect any offences.

class User < ApplicationRecord
  scope :published3, (lambda do
                        baz
                      end)

  scope :published4, (
        -> { car }
      )
end

koic added a commit to koic/rubocop that referenced this issue Nov 10, 2023
… or proc

Fixes rubocop#12380.

This PR makes `Style/RedundantParentheses` aware of lambda or proc.
koic added a commit that referenced this issue Nov 13, 2023
…aware_of_lambda_or_proc

[Fix #12380] Make `Style/RedundantParentheses` aware of lambda or proc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants