[Fix rubocop#12380] Make Style/RedundantParentheses aware of lambda…

… or proc Fixes rubocop#12380. This PR makes `Style/RedundantParentheses` aware of lambda or proc.
koic · Nov 10, 2023 · 2bb0bc7 · 2bb0bc7
1 parent 80fce12
commit 2bb0bc7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/changelog/change_make_style_redundant_parentheses_aware_of_lambda_or_proc.md b/changelog/change_make_style_redundant_parentheses_aware_of_lambda_or_proc.md
@@ -0,0 +1 @@
+* [#12380](https://github.com/rubocop/rubocop/issues/12380): Make `Style/RedundantParentheses` aware of lambda or proc. ([@koic][])
diff --git a/lib/rubocop/cop/style/redundant_parentheses.rb b/lib/rubocop/cop/style/redundant_parentheses.rb
@@ -138,12 +138,13 @@ def check(begin_node)
           check_send(begin_node, node) if node.call_type?
         end
 
-        # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
         def find_offense_message(begin_node, node)
           return 'a keyword' if keyword_with_redundant_parentheses?(node)
           return 'a literal' if disallowed_literal?(begin_node, node)
           return 'a variable' if node.variable?
           return 'a constant' if node.const_type?
+          return 'an expression' if node.lambda_or_proc?
           return 'an interpolated expression' if interpolation?(begin_node)
 
           return if begin_node.chained?
@@ -159,7 +160,7 @@ def find_offense_message(begin_node, node)
             'a comparison expression'
           end
         end
-        # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
 
         # @!method interpolation?(node)
         def_node_matcher :interpolation?, '[^begin ^^dstr]'

diff --git a/spec/rubocop/cop/style/redundant_parentheses_spec.rb b/spec/rubocop/cop/style/redundant_parentheses_spec.rb
@@ -150,6 +150,10 @@
 
   it_behaves_like 'redundant', '(X)', 'X', 'a constant'
 
+  it_behaves_like 'redundant', '(-> { x })', '-> { x }', 'an expression'
+  it_behaves_like 'redundant', '(lambda { x })', 'lambda { x }', 'an expression'
+  it_behaves_like 'redundant', '(proc { x })', 'proc { x }', 'an expression'
+
   it_behaves_like 'redundant', '(x)', 'x', 'a method call'
   it_behaves_like 'redundant', '(x(1, 2))', 'x(1, 2)', 'a method call'
   it_behaves_like 'redundant', '("x".to_sym)', '"x".to_sym', 'a method call'