Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive on Layout/MultilineMethodCallIndentation cop #12226

Closed
ydakuka opened this issue Sep 28, 2023 · 0 comments · Fixed by #12230
Closed

False positive on Layout/MultilineMethodCallIndentation cop #12226

ydakuka opened this issue Sep 28, 2023 · 0 comments · Fixed by #12230
Labels

Comments

@ydakuka
Copy link

ydakuka commented Sep 28, 2023

Expected behavior

No changes.

Actual behavior

Before

def banner_ids_params
  params[:included].find do |data|
    data[:type] == 'ads'
  end&.dig('relationships', 'banners', 'data')
     &.map { |param| Integer(param['id']) }
end

After

def banner_ids_params
  params[:included].find do |data|
    data[:type] == 'ads'
  end&.dig('relationships', 'banners', 'data')
                   &.map { |param| Integer(param['id']) }
end

RuboCop version

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.56.4 (using Parser 3.2.2.3, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.21.1
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.24.0
  - rubocop-thread_safety 0.5.1
@koic koic added the bug label Sep 29, 2023
koic added a commit to koic/rubocop that referenced this issue Sep 30, 2023
…llIndentation`

Fixes rubocop#12226.

This PR fixes false positives for `Layout/MultilineMethodCallIndentation`
when aligning methods in multiline block chain.
bbatsov pushed a commit that referenced this issue Sep 30, 2023
…tation`

Fixes #12226.

This PR fixes false positives for `Layout/MultilineMethodCallIndentation`
when aligning methods in multiline block chain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants