Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Gemspec/DependencyVersion #11691

Merged

Conversation

koic
Copy link
Member

@koic koic commented Mar 12, 2023

This PR fixes the following error for Gemspec/DependencyVersion when add_dependency without version argument and method called on gem name argument:

Gem::Specification.new do |spec|
  spec.add_dependency('parser'.freeze)
end
$ bundle exec rubocop --only Gemspec/DependencyVersion -d
(snip)

undefined method `value' for s(:send,
  s(:str, "parser"), :freeze):RuboCop::AST::SendNode
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/gemspec/dependency_version.rb:97:in `allowed_gem?'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/gemspec/dependency_version.rb:84:in `on_send'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/commissioner.rb:143:in `public_send'

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following error for `Gemspec/DependencyVersion`
when `add_dependency` without version argument and method called on gem name argument:

```ruby
Gem::Specification.new do |spec|
  spec.add_dependency('parser'.freeze)
end
```

```console
$ bundle exec rubocop --only Gemspec/DependencyVersion -d
(snip)

undefined method `value' for s(:send,
  s(:str, "parser"), :freeze):RuboCop::AST::SendNode
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/gemspec/dependency_version.rb:97:in `allowed_gem?'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/gemspec/dependency_version.rb:84:in `on_send'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/commissioner.rb:143:in `public_send'
```
@koic koic merged commit e79974b into rubocop:master Mar 12, 2023
@koic koic deleted the fix_an_error_for_gemspec_dependency_version branch March 12, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant