[Fix #12353] Add new Style/SuperWithArgsParentheses cop

Fixes #12353.

This PR adds new `Style/SuperWithArgsParentheses` cop

```ruby
# bad
super name, age

# good
super(name, age)
```

The cop is named `Style/SuperWithArgsParentheses`, contrasting with `Style/MethodCallWithArgsParentheses`.
Unlike `Style/MethodCallWithArgsParentheses`, which requires consideration for no-parentheses usage in DSL.
`super` is not used as a DSL, so it is enabled by default.

For these reasons, it has been made into a separate, new cop.

changelog/new_add_new_style_super_with_args_parentheses_cop.md

@@ -0,0 +1 @@
+* [#12353](https://github.com/rubocop/rubocop/issues/12353): Add new `Style/SuperWithArgsParentheses` cop. ([@koic][])

config/default.yml

@@ -5334,6 +5334,12 @@ Style/StructInheritance:
   VersionAdded: '0.29'
   VersionChanged: '1.20'
 
+Style/SuperWithArgsParentheses:
+  Description: 'Use parentheses for `super` with arguments.'
+  StyleGuide: '#super-with-args'
+  Enabled: pending
+  VersionAdded: '<<next>>'
+
 Style/SwapValues:
   Description: 'Enforces the use of shorthand-style swapping of 2 variables.'
   StyleGuide: '#values-swapping'

lib/rubocop.rb

@@ -678,6 +678,7 @@
 require_relative 'rubocop/cop/style/string_methods'
 require_relative 'rubocop/cop/style/strip'
 require_relative 'rubocop/cop/style/struct_inheritance'
+require_relative 'rubocop/cop/style/super_with_args_parentheses'
 require_relative 'rubocop/cop/style/swap_values'
 require_relative 'rubocop/cop/style/symbol_array'
 require_relative 'rubocop/cop/style/symbol_literal'

lib/rubocop/cop/style/super_with_args_parentheses.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Style
+      # Enforces the presence of parentheses in `super` containing arguments.
+      #
+      # `super` is a keyword and is provided as a distinct cop from those designed for method call.
+      #
+      # @example
+      #
+      #   # bad
+      #   super name, age
+      #
+      #   # good
+      #   super(name, age)
+      #
+      class SuperWithArgsParentheses < Base
+        extend AutoCorrector
+
+        MSG = 'Use parentheses for `super` with arguments.'
+
+        def on_super(node)
+          return if node.parenthesized?
+
+          add_offense(node) do |corrector|
+            range = node.loc.keyword.end.join(node.first_argument.source_range.begin)
+            corrector.replace(range, '(')
+            corrector.insert_after(node.last_argument, ')')
+          end
+        end
+      end
+    end
+  end
+end

lib/rubocop/runner.rb

@@ -20,7 +20,7 @@ def initialize(path, offenses_by_iteration, loop_start: -1)
         message = 'Infinite loop detected'
         message += " in #{path}" if path
         message += " and caused by #{root_cause}" if root_cause
-        super message
+        super(message)
       end
     end
 

spec/rubocop/cop/style/super_with_args_parentheses_spec.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::Cop::Style::SuperWithArgsParentheses, :config do
+  it 'registers an offense when using `super` without parenthesized arguments' do
+    expect_offense(<<~RUBY)
+      super name, age
+      ^^^^^^^^^^^^^^^ Use parentheses for `super` with arguments.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      super(name, age)
+    RUBY
+  end
+
+  it 'does not register an offense when using `super` with parenthesized arguments' do
+    expect_no_offenses(<<~RUBY)
+      super(name, age)
+    RUBY
+  end
+
+  it 'does not register an offense when using `super` without arguments' do
+    expect_no_offenses(<<~RUBY)
+      super()
+    RUBY
+  end
+
+  it 'does not register an offense when using zero arity `super`' do
+    expect_no_offenses(<<~RUBY)
+      super
+    RUBY
+  end
+end