Merge pull request #12207 from koic/fix_an_error_for_style_operator_m…

…ethod_call [Fix #12205] Fix an error for `Style/OperatorMethodCall`
rubocop · Sep 19, 2023 · d6b5ecf · d6b5ecf
2 parents 1af7e11 + ed9a4bd
commit d6b5ecf
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/changelog/fix_an_error_for_style_operator_method_call.md b/changelog/fix_an_error_for_style_operator_method_call.md
@@ -0,0 +1 @@
+* [#12205](https://github.com/rubocop/rubocop/issues/12205): Fix an error for `Style/OperatorMethodCall` when using `foo bar./ baz`. ([@koic][])
diff --git a/lib/rubocop/cop/style/operator_method_call.rb b/lib/rubocop/cop/style/operator_method_call.rb
@@ -54,6 +54,7 @@ def anonymous_forwarding?(argument)
 
         def wrap_in_parentheses_if_chained(corrector, node)
           return unless node.parent&.call_type?
+          return if node.parent.first_argument == node
 
           operator = node.loc.selector
 

diff --git a/spec/rubocop/cop/style/operator_method_call_spec.rb b/spec/rubocop/cop/style/operator_method_call_spec.rb
@@ -30,6 +30,17 @@
       RUBY
     end
 
+    it "registers an offense when using `foo bar.#{operator_method} baz`" do
+      expect_offense(<<~RUBY)
+        foo bar.#{operator_method} baz
+               ^ Redundant dot detected.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        foo bar #{operator_method} baz
+      RUBY
+    end
+
     it "registers an offense when using `foo.#{operator_method}(bar)`" do
       expect_offense(<<~RUBY, operator_method: operator_method)
         foo.#{operator_method}(bar)