Merge pull request #12780 from Earlopain/fix-error-for-style-redundan…

…t-each Fix an error for `Style/RedundantEach` when using `reverse_each.each` without a block
rubocop · Mar 11, 2024 · d2eb99c · d2eb99c
2 parents 1973bad + 18f967d
commit d2eb99c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/changelog/fix_an_error_for_style_redundant_each.md b/changelog/fix_an_error_for_style_redundant_each.md
@@ -0,0 +1 @@
+* [#12780](https://github.com/rubocop/rubocop/issues/12780): Fix an error for `Style/RedundantEach` when using `reverse_each.each` without a block. ([@earlopain][])
diff --git a/lib/rubocop/cop/style/redundant_each.rb b/lib/rubocop/cop/style/redundant_each.rb
@@ -86,7 +86,7 @@ def redundant_each_method(node)
         def range(node)
           return node.selector unless node.method?(:each)
 
-          if node.parent.call_type?
+          if node.parent&.call_type?
             node.selector.join(node.parent.loc.dot)
           else
             node.loc.dot.join(node.selector)

diff --git a/spec/rubocop/cop/style/redundant_each_spec.rb b/spec/rubocop/cop/style/redundant_each_spec.rb
@@ -115,6 +115,17 @@
     RUBY
   end
 
+  it 'registers an offense when using `reverse_each.each` without a block' do
+    expect_offense(<<~RUBY)
+      context.reverse_each.each
+                          ^^^^^ Remove redundant `each`.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      context.reverse_each
+    RUBY
+  end
+
   it 'registers an offense when using `reverse_each&.each`' do
     expect_offense(<<~RUBY)
       context.reverse_each&.each { |i| do_something(i) }