Revert "[Fix #12649] Fix false positives for Style/InverseMethods"

This reverts commit 7b87261.
rubocop · Feb 15, 2024 · ad79a1e · ad79a1e
1 parent 7b87261
commit ad79a1e
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 31 deletions.
diff --git a/changelog/fix_false_positives_for_style_inverse_methods.md b/changelog/fix_false_positives_for_style_inverse_methods.md
diff --git a/lib/rubocop/cop/style/inverse_methods.rb b/lib/rubocop/cop/style/inverse_methods.rb
@@ -76,9 +76,9 @@ def self.autocorrect_incompatible_with
         PATTERN
 
         def on_send(node)
-          inverse_candidate?(node) do |method_call, lhs, method, rhs|
+          inverse_candidate?(node) do |_method_call, lhs, method, rhs|
             return unless inverse_methods.key?(method)
-            return if negated?(node) || relational_comparison_with_safe_navigation?(method_call)
+            return if negated?(node)
             return if part_of_ignored_node?(node)
             return if possible_class_hierarchy_check?(lhs, rhs, method)
 
@@ -155,10 +155,6 @@ def negated?(node)
           node.parent.respond_to?(:method?) && node.parent.method?(:!)
         end
 
-        def relational_comparison_with_safe_navigation?(node)
-          node.csend_type? && CLASS_COMPARISON_METHODS.include?(node.method_name)
-        end
-
         def not_to_receiver(node, method_call)
           node.loc.selector.begin.join(method_call.source_range.begin)
         end

diff --git a/spec/rubocop/cop/style/inverse_methods_spec.rb b/spec/rubocop/cop/style/inverse_methods_spec.rb
@@ -209,30 +209,6 @@ def test_method
     end
   end
 
-  it 'allows comparing for relational comparison operator (`<`) with safe navigation operator' do
-    expect_no_offenses(<<~RUBY)
-      !nullable&.<(0)
-    RUBY
-  end
-
-  it 'allows comparing for relational comparison operator (`<=`) with safe navigation operator' do
-    expect_no_offenses(<<~RUBY)
-      !nullable&.<=(0)
-    RUBY
-  end
-
-  it 'allows comparing for relational comparison operator (`>`) with safe navigation operator' do
-    expect_no_offenses(<<~RUBY)
-      !nullable&.>(0)
-    RUBY
-  end
-
-  it 'allows comparing for relational comparison operator (`>=`) with safe navigation operator' do
-    expect_no_offenses(<<~RUBY)
-      !nullable&.>=(0)
-    RUBY
-  end
-
   it 'allows comparing camel case constants on the right' do
     expect_no_offenses(<<~RUBY)
       klass = self.class