Merge pull request #12563 from koic/fix_false_positives_for_style_red…

…undant_parentheses

[Fix #12556] Fix false positives for `Style/RedundantParentheses`

changelog/fix_false_positives_for_style_redundant_parentheses.md

@@ -0,0 +1 @@
+* [#12556](https://github.com/rubocop/rubocop/issues/12556): Fix false positives for `Style/RedundantParentheses` when parentheses are used around a semantic operator in expressions within assignments. ([@koic][])

lib/rubocop/cop/style/redundant_parentheses.rb

@@ -150,6 +150,7 @@ def find_offense_message(begin_node, node)
           return if begin_node.chained?
 
           if node.and_type? || node.or_type?
+            return if node.semantic_operator? && begin_node.parent
             return if node.multiline? && allow_in_multiline_conditions?
             return if ALLOWED_NODE_TYPES.include?(begin_node.parent&.type)
             return if begin_node.parent&.if_type? && begin_node.parent&.ternary?

spec/rubocop/cop/style/redundant_parentheses_spec.rb

@@ -508,6 +508,36 @@ def x
     RUBY
   end
 
+  it 'registers an offense when the use of parentheses around `&&` expressions in assignment' do
+    expect_offense(<<~RUBY)
+      var = (foo && bar)
+            ^^^^^^^^^^^^ Don't use parentheses around a logical expression.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      var = foo && bar
+    RUBY
+  end
+
+  it 'registers an offense when the use of parentheses around `||` expressions in assignment' do
+    expect_offense(<<~RUBY)
+      var = (foo || bar)
+            ^^^^^^^^^^^^ Don't use parentheses around a logical expression.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      var = foo || bar
+    RUBY
+  end
+
+  it 'accepts the use of parentheses around `or` expressions in assignment' do
+    expect_no_offenses('var = (foo or bar)')
+  end
+
+  it 'accepts the use of parentheses around `and` expressions in assignment' do
+    expect_no_offenses('var = (foo and bar)')
+  end
+
   it 'accepts parentheses around a method call with unparenthesized arguments' do
     expect_no_offenses('(a 1, 2) && (1 + 1)')
   end