[Fix #12117] Fix Style/ArgumentsForwarding when not always forwardi…

…ng a block

changelog/fix_an_error_for_style_arguments_forwarding_when_not_always_forwarding_block.md

@@ -0,0 +1 @@
+* [#12117](https://github.com/rubocop/rubocop/issues/12117): Fix a false positive for `Style/ArgumentsForwarding` cop when not always forwarding block. ([@owst][])

lib/rubocop/cop/style/arguments_forwarding.rb

@@ -280,7 +280,7 @@ def classification
 
             if can_forward_all?
               :all
-            elsif target_ruby_version >= 3.2
+            else
               :rest_or_kwrest
             end
           end

spec/rubocop/cop/style/arguments_forwarding_spec.rb

@@ -240,6 +240,34 @@ def foo(*args, &block)
       RUBY
     end
 
+    it 'does not register an offense when not always passing the block as well as restarg' do
+      expect_no_offenses(<<~RUBY)
+        def foo(*args, &block)
+          bar(*args, &block)
+          baz(*args)
+        end
+      RUBY
+    end
+
+    it 'does not register an offense when not always passing the block as well as kwrestarg' do
+      expect_no_offenses(<<~RUBY)
+        def foo(**kwargs, &block)
+          bar(**kwargs, &block)
+          baz(**kwargs)
+        end
+      RUBY
+    end
+
+    it 'does not register an offense when not always forwarding all' do
+      expect_no_offenses(<<~RUBY)
+        def foo(*args, **kwargs, &block)
+          bar(*args, **kwargs, &block)
+          bar(*args, &block)
+          bar(**kwargs, &block)
+        end
+      RUBY
+    end
+
     it 'does not register an offense when body of method definition is empty' do
       expect_no_offenses(<<~RUBY)
         def foo(*args, &block)
@@ -956,6 +984,68 @@ def foo(*, **, &block)
       RUBY
     end
 
+    it 'registers an offense when not always passing the block as well as restarg' do
+      expect_offense(<<~RUBY)
+        def foo(*args, &block)
+                ^^^^^ Use anonymous positional arguments forwarding (`*`).
+          bar(*args, &block)
+              ^^^^^ Use anonymous positional arguments forwarding (`*`).
+          baz(*args)
+              ^^^^^ Use anonymous positional arguments forwarding (`*`).
+        end
+      RUBY
+
+      expect_correction(<<~RUBY)
+        def foo(*, &block)
+          bar(*, &block)
+          baz(*)
+        end
+      RUBY
+    end
+
+    it 'registers an offense when not always passing the block as well as kwrestarg' do
+      expect_offense(<<~RUBY)
+        def foo(**kwargs, &block)
+                ^^^^^^^^ Use anonymous keyword arguments forwarding (`**`).
+          bar(**kwargs, &block)
+              ^^^^^^^^ Use anonymous keyword arguments forwarding (`**`).
+          baz(**kwargs)
+              ^^^^^^^^ Use anonymous keyword arguments forwarding (`**`).
+        end
+      RUBY
+
+      expect_correction(<<~RUBY)
+        def foo(**, &block)
+          bar(**, &block)
+          baz(**)
+        end
+      RUBY
+    end
+
+    it 'registers an offense when not always forwarding all' do
+      expect_offense(<<~RUBY)
+        def foo(*args, **kwargs, &block)
+                ^^^^^ Use anonymous positional arguments forwarding (`*`).
+                       ^^^^^^^^ Use anonymous keyword arguments forwarding (`**`).
+          bar(*args, **kwargs, &block)
+              ^^^^^ Use anonymous positional arguments forwarding (`*`).
+                     ^^^^^^^^ Use anonymous keyword arguments forwarding (`**`).
+          bar(*args, &block)
+              ^^^^^ Use anonymous positional arguments forwarding (`*`).
+          bar(**kwargs, &block)
+              ^^^^^^^^ Use anonymous keyword arguments forwarding (`**`).
+        end
+      RUBY
+
+      expect_correction(<<~RUBY)
+        def foo(*, **, &block)
+          bar(*, **, &block)
+          bar(*, &block)
+          bar(**, &block)
+        end
+      RUBY
+    end
+
     it 'registers an offense for restarg when passing block to separate call' do
       expect_offense(<<~RUBY)
         def foo(*args, &block)