Fix an error for Lint/RedundantWithIndex when there is no receiver

rubocop · Mar 10, 2024 · 5d0e3b1 · 5d0e3b1
1 parent 55cbc7f
commit 5d0e3b1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/changelog/fix_an_error_for_lint_redundant_with_index.md b/changelog/fix_an_error_for_lint_redundant_with_index.md
@@ -0,0 +1 @@
+* [#12770](https://github.com/rubocop/rubocop/pull/12770): Fix an error for `Lint/RedundantWithIndex` when the method has no receiver. ([@earlopain][])
diff --git a/lib/rubocop/cop/lint/redundant_with_index.rb b/lib/rubocop/cop/lint/redundant_with_index.rb
@@ -56,10 +56,10 @@ def on_block(node)
         def_node_matcher :redundant_with_index?, <<~PATTERN
           {
             (block
-              $(call _ {:each_with_index :with_index} ...)
+              $(call ^_ {:each_with_index :with_index} ...)
               (args (arg _)) ...)
             (numblock
-              $(call _ {:each_with_index :with_index} ...) 1 ...)
+              $(call ^_ {:each_with_index :with_index} ...) 1 ...)
           }
         PATTERN
 

diff --git a/spec/rubocop/cop/lint/redundant_with_index_spec.rb b/spec/rubocop/cop/lint/redundant_with_index_spec.rb
@@ -100,5 +100,13 @@
     it 'accepts an index is used as a numblock argument' do
       expect_no_offenses('ary.each_with_index { _1; _2 }')
     end
+
+    it 'accepts with_index without receiver with a block' do
+      expect_no_offenses('with_index { |v| v }')
+    end
+
+    it 'accepts with_index without receiver with a numblock' do
+      expect_no_offenses('with_index { _1 }')
+    end
   end
 end