Merge pull request #12439 from koic/fix_a_false_positive_for_lint_sel…

…f_assignment [Fix #12435] Fix a false positive for `Lint/SelfAssignment`
rubocop · Dec 5, 2023 · 3745a3c · 3745a3c
2 parents 3b31891 + c7ff1a4
commit 3745a3c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/changelog/fix_a_false_positive_for_lint_self_assignment.md b/changelog/fix_a_false_positive_for_lint_self_assignment.md
@@ -0,0 +1 @@
+* [#12435](https://github.com/rubocop/rubocop/issues/12435): Fix a false positive for `Lint/SelfAssignment` when using attribute assignment with method call with arguments. ([@koic][])
diff --git a/lib/rubocop/cop/lint/self_assignment.rb b/lib/rubocop/cop/lint/self_assignment.rb
@@ -102,6 +102,7 @@ def handle_key_assignment(node)
 
         def handle_attribute_assignment(node)
           first_argument = node.first_argument
+          return unless first_argument.respond_to?(:arguments) && first_argument.arguments.empty?
 
           if first_argument.call_type? &&
              node.receiver == first_argument.receiver &&

diff --git a/spec/rubocop/cop/lint/self_assignment_spec.rb b/spec/rubocop/cop/lint/self_assignment_spec.rb
@@ -162,6 +162,18 @@
     RUBY
   end
 
+  it 'does not register an offense when using attribute assignment with method call with arguments' do
+    expect_no_offenses(<<~RUBY)
+      foo.bar = foo.bar(arg)
+    RUBY
+  end
+
+  it 'does not register an offense when using attribute assignment with literals' do
+    expect_no_offenses(<<~RUBY)
+      foo.bar = true
+    RUBY
+  end
+
   it 'registers an offense when using []= self-assignment with same string literals' do
     expect_offense(<<~RUBY)
       foo["bar"] = foo["bar"]