Merge pull request #12796 from koic/fix_false_positives_for_style_eva…

…l_with_location Fix false positives for `Style/EvalWithLocation`
rubocop · Mar 18, 2024 · 23ad8e1 · 23ad8e1
2 parents e682185 + fd30cf6
commit 23ad8e1
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/changelog/fix_false_positives_for_style_eval_with_location.md b/changelog/fix_false_positives_for_style_eval_with_location.md
@@ -0,0 +1 @@
+* [#12796](https://github.com/rubocop/rubocop/pull/12796): Fix false positives for `Style/EvalWithLocation` when using `eval` with a line number from a method call or a variable. ([@koic][])
diff --git a/lib/rubocop/cop/style/eval_with_location.rb b/lib/rubocop/cop/style/eval_with_location.rb
@@ -155,6 +155,8 @@ def check_file(node, file_node)
 
         def check_line(node, code)
           line_node = node.last_argument
+          return if line_node.variable? || (line_node.send_type? && !line_node.method?(:+))
+
           line_diff = line_difference(line_node, code)
           if line_diff.zero?
             add_offense_for_same_line(node, line_node)

diff --git a/spec/rubocop/cop/style/eval_with_location_spec.rb b/spec/rubocop/cop/style/eval_with_location_spec.rb
@@ -315,4 +315,22 @@ def self.included(base)
       end
     RUBY
   end
+
+  it 'does not register an offense when using eval with a line number from a method call' do
+    expect_no_offenses(<<~RUBY)
+      module_eval(<<~CODE, __FILE__, lineno)
+        do_something
+      CODE
+    RUBY
+  end
+
+  it 'does not register an offense when using eval with a line number from a variable' do
+    expect_no_offenses(<<~RUBY)
+      lineno = calc
+
+      module_eval(<<~CODE, __FILE__, lineno)
+        do_something
+      CODE
+    RUBY
+  end
 end