Merge pull request #11939 from FnControlRuby/def_node_matcher

Use unification to match `File.open` block param with `#read` receiver
rubocop · Jun 8, 2023 · 01b5714 · 01b5714
2 parents 13a39cc + c2e024b
commit 01b5714
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/rubocop/cop/style/file_read.rb b/lib/rubocop/cop/style/file_read.rb
@@ -63,7 +63,7 @@ class FileRead < Base
 
         # @!method block_read?(node)
         def_node_matcher :block_read?, <<~PATTERN
-          (block _ (args (arg $_)) (send (lvar $_) :read))
+          (block _ (args (arg _name)) (send (lvar _name) :read))
         PATTERN
 
         def on_send(node)
@@ -100,7 +100,7 @@ def read_node?(node, block_pass)
         def file_open_read?(node)
           return true if send_read?(node)
 
-          block_read?(node) { |block_arg, read_lvar| block_arg == read_lvar }
+          block_read?(node)
         end
 
         def read_method(mode)