Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for RSpec/SharedExamples when using examples without argument #1768

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Jan 5, 2024

Fix: #1765


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • [-] Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@ydah ydah requested a review from a team as a code owner January 5, 2024 13:45
@Tabby
Copy link

Tabby commented Jan 5, 2024

Thanks @ydah, you beat me to it :)

I can confirm that this fixes the issue in the repo where I was seeing it

Copy link
Collaborator

@bquorning bquorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@bquorning bquorning merged commit 6e19ee6 into master Jan 5, 2024
24 checks passed
@bquorning bquorning deleted the fix1765 branch January 5, 2024 14:05
ydah added a commit that referenced this pull request Jan 5, 2024
ydah added a commit that referenced this pull request Jan 5, 2024
ydah added a commit that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.26.0 regression: undefined method 'sym_type?' for nil:NilClass
4 participants