Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support it block parameter in Rails cops #1471

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

koic
Copy link
Member

@koic koic commented Mar 27, 2025

This PR supports it block parameter in Rails cops.

Closes #1413


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Sorry, something went wrong.

This PR supports `it` block parameter in `Rails` cops.

Closes rubocop#1413
@koic koic force-pushed the support_itblock_in_rails_cops branch from caa9f09 to 72155fd Compare March 27, 2025 04:29
@koic koic merged commit 2420d70 into rubocop:master Mar 28, 2025
16 checks passed
@koic koic deleted the support_itblock_in_rails_cops branch March 28, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/CreateTableWithTimestamps should consider it
1 participant