Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect behavior when using AllCops: MigratedSchemaVersion #1444

Conversation

koic
Copy link
Member

@koic koic commented Feb 16, 2025

This PR fixes an incorrect behavior when using AllCops: MigratedSchemaVersion.

This suppresses the following warning when MigratedSchemaVersion is defined on the user side:

$ bundle exec rubocop
(snip)

Warning: AllCops does not support MigratedSchemaVersion parameter.

Supported parameters are:

  - RubyInterpreters
  - Include
  - Exclude
  - DefaultFormatter
  - DisplayCopNames
  - DisplayStyleGuide
  - StyleGuideBaseURL
  - DocumentationBaseURL
  - DocumentationExtension
  - ExtraDetails
  - StyleGuideCopsOnly
  - EnabledByDefault
  - DisabledByDefault
  - NewCops
  - UseCache
  - MaxFilesInCache
  - CacheRootDirectory
  - AllowSymlinksInCacheRootDirectory
  - TargetRubyVersion
  - ParserEngine
  - SuggestExtensions
  - ActiveSupportExtensionsEnabled
  - StringLiteralsFrozenByDefault

The default value of AllCops: MigratedSchemaVersion in config/default.yml will change from null to the UNIX epoch time, but typically, there should be no migration files older than the UNIX epoch time.

This is a bug fix related to the plugin migration in #1434.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Sorry, something went wrong.

This PR fixes an incorrect behavior when using `AllCops: MigratedSchemaVersion`.

This suppresses the following warning when `MigratedSchemaVersion` is defined on the user side:

```console
$ bundle exec rubocop
(snip)

Warning: AllCops does not support MigratedSchemaVersion parameter.

Supported parameters are:

  - RubyInterpreters
  - Include
  - Exclude
  - DefaultFormatter
  - DisplayCopNames
  - DisplayStyleGuide
  - StyleGuideBaseURL
  - DocumentationBaseURL
  - DocumentationExtension
  - ExtraDetails
  - StyleGuideCopsOnly
  - EnabledByDefault
  - DisabledByDefault
  - NewCops
  - UseCache
  - MaxFilesInCache
  - CacheRootDirectory
  - AllowSymlinksInCacheRootDirectory
  - TargetRubyVersion
  - ParserEngine
  - SuggestExtensions
  - ActiveSupportExtensionsEnabled
  - StringLiteralsFrozenByDefault
```

The default value of `AllCops: MigratedSchemaVersion` in `config/default.yml` will change from `null` to the UNIX epoch time,
but typically, there should be no migration files older than the UNIX epoch time.

This is a bug fix related to the plugin migration in rubocop#1434.
@koic koic merged commit d8bb510 into rubocop:master Feb 17, 2025
16 checks passed
@koic koic deleted the fix_an_incorrect_behavior_when_using_migrated_schema_version branch February 17, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant