Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #1200] Make Rails/TimeZone aware of safe navigation #1251

Merged
merged 1 commit into from
Mar 21, 2024
Merged

[Fix #1200] Make Rails/TimeZone aware of safe navigation #1251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/fix_make_rails_time_zone_aware_of_safe_navigation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* [#1200](https://github.com/rubocop/rubocop-rails/issues/1200): Make `Rails/TimeZone` aware of safe navigation. ([@earlopain][])
3 changes: 2 additions & 1 deletion lib/rubocop/cop/rails/time_zone.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,10 @@ def on_send(node)
return if !node.receiver&.str_type? || !node.method?(:to_time)

add_offense(node.loc.selector, message: MSG_STRING_TO_TIME) do |corrector|
corrector.replace(node, "Time.zone.parse(#{node.receiver.source})")
corrector.replace(node, "Time.zone.parse(#{node.receiver.source})") unless node.csend_type?
end
end
alias on_csend on_send

private

Expand Down
9 changes: 9 additions & 0 deletions spec/rubocop/cop/rails/time_zone_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,15 @@
RUBY
end

it 'registers an offense for `to_time` with safe navigation' do
expect_offense(<<~RUBY)
"2012-03-02 16:05:37"&.to_time
^^^^^^^ Do not use `String#to_time` without zone. Use `Time.zone.parse` instead.
RUBY

expect_no_corrections
end

it 'does not register an offense for `to_time` without receiver' do
expect_no_offenses(<<~RUBY)
to_time
Expand Down